Tag code-review

Comments that are easy to grok and grep

Where did nitpicking come from in terms of code reviews? If it is something worth you making a comment about it, does that not warrant a change?

Josie (@javavvitch)Mon, 11 Apr 2022 16:00 +0000

What is code review? It's both looking over the code personally, and letting the linter - with rules...

What to focus on during a code review? Don't waste your time with automatable formalities like code style. Rather spend your review budget on those aspects which will be hard/expensive to change later on. The "Code Review Pyramid" provides some guidance on what to look for.

Gunnar Morling 🌍 (@gunnarmorling)Wed, 09 Mar 2022 19:44 GMT

push it straight to main, it will be fine

Molly Struve 🦄 (@molly_struve)Sat, 22 Jan 2022 19:04 GMT

Is there a service that anyone knows of that provides third-party code review? I'm wondering if there's a service where a senior developer/engineer would give unbiased feedback. Anyone know of a service or person who does something similar? Thanks in advance.

Ryan Don Sullivan ⤴️ (@ryandonsullivan)Wed, 10 Nov 2021 21:21 GMT

If you think pair programming is inefficient, try waiting hours to get your code reviewed & having to context switch between tasks while you wait. And then switch back when you get the feedback & have to rethink your approach because you weren’t discussing it as you wrote it.

Jez Humble (@jezhumble)Thu, 04 Nov 2021 03:25 GMT

Putting up with poorly motivated nitpicking on my code reviews (after initially fighting back and being told I should cooperate). Then when I gave a critical code comments to that same man, got a huge tantrum about how unfair I was being.

Post details

What are some subtle sexist behaviors you noticed or experienced in the workplace?

Cake is Kate. Always has been 💫 (@kefimochi)Fri, 29 Oct 2021 03:33 +0000

Shantini (@_shantini_)Fri, 29 Oct 2021 15:52 +0000

In tech, we don't say "I love you." We say "just reviewed your PR 🙌" And I think that's really beautiful.

Cake is Kate. Always has been 💫 (@kefimochi)Wed, 13 Oct 2021 16:43 +0000

Code review is a skill. It takes practice.

Laurie (@laurieontech)Wed, 09 Jun 2021 14:07 +0000

One of the biggest cultural shifts in my experience from Mozilla to Stripe is code review speed. At Mozilla you'd often wait days and have to hunt down people to review PRs. At Stripe my PR is often reviewed within 10 minutes. That makes a _huge_ difference for shipping fast

James Long (@jlongster)Thu, 03 Jun 2021 17:55 +0000

kim  (@kaydacode)Fri, 21 May 2021 15:43 +0000

Not all code review comments should be criticism! Did you learn something new? “Nice! Didn’t know you could do that” Do you have a question? Ask it and don’t jump right to a correction. Async written communication is hard. But it should reflect all your reactions. #devdiscuss

Laurie (@laurieontech)Wed, 19 May 2021 01:17 +0000

These are the tech tips my bio is referencing 😘

Emily Kager (@EmilyKager)Fri, 14 May 2021 19:08 +0000

Something that no one taught me and I wish I’d learnt on day one: When reviewing PRs, switching between unified or split diff makes them so much easier to parse depending on the type of changes you’re working on. I sometimes switch even within a single PR 🙌🏼

Carol 🌻 (@CarolSaysThings)Thu, 08 Apr 2021 09:52 +0000

Open source friends: what are the best pieces of "Git/GitHub etiquette" you've picked up over the years? Things like submitting large changes commit-by-commit to help reviewers out.

Celeste Horgan (@celeste_horgan)Thu, 25 Mar 2021 21:06 GMT

Tired: Begging your team for code review. Wired: Click-baiting them to your PR.

😸 matt zabriskie 🤖 (@mzabriskie)Fri, 19 Feb 2021 23:31 GMT

PR reviews

Post details

What’s something that FEELS like a personal attack on you but isn’t?

holly✨ (@hollyshortall)Thu, 12 Nov 2020 10:12 GMT

Tierney Cyren 🍑 (@bitandbang)Fri, 13 Nov 2020 17:34 GMT

I’ve reviewed over 750 PR’s at AWS. As my team’s tech lead I provide insightful feedback and enforce a high code quality bar. But as a jr engineer I couldn’t review code. I didn’t know where to start, what to look for or how to comment. Here’s how I review PR’s. 🧵 👇

Curtis Einsmann (@curtiseinsmann)Fri, 16 Oct 2020 17:04 +0000

Gonna miss this kid. @SawyerBlatz 's last review 😭

Emily (@EmilyKager)Sat, 26 Sep 2020 00:00 +0000

when no one wants to review my PR

Nov3 #ElectionDay #BlackLivesMatter✊🏿 #Ally🏳️‍🌈 (@novallkhan)Mon, 31 Aug 2020 18:09 +0000

https://twitter.com/zkat__/status/1296130087314534401

He brought it up because he noticed a stark contrast between what I comment on and what some others comment on My 2c is that death by 1000 cuts is never worth it for style comments, and they're usually a waste of everyone's time Automate format/linting. You owe it to each other

Kat Marchán 😷 (@zkat__)Wed, 19 Aug 2020 17:01 +0000

Would be interesting for teams to have (informal) code review reviews once or twice yearly to calibrate nit-picking levels and gauge the split in focus between syntax, structure and UX/DX. You can write docs for this stuff but I think many of us can learn from each other.

زهرة || zahra (@zahrataiba)Wed, 12 Aug 2020 11:02 +0000